backfill [VerbResult] attributes on Command methods (#527)#534
Draft
PolyphonyRequiem wants to merge 1 commit into
Draft
backfill [VerbResult] attributes on Command methods (#527)#534PolyphonyRequiem wants to merge 1 commit into
PolyphonyRequiem wants to merge 1 commit into
Conversation
- All 109 Command methods confirmed annotated (0 were missing); attributes were already present across all command files from prior incremental work - Regenerated artifacts/verb-output-schemas.json (276848 bytes) from clean SchemaExporter build; force-added since artifacts/ is in .gitignore - Updated global.json: preview.3 → preview.4 (only installed SDK version) - In-situ DU hygiene: replaced IUnion cast pattern with native 'is' pattern matching in TransitionValidatorTests and CrossProcessTransitionValidatorTests (CS0433 ambiguity between System.Runtime.IUnion and Twig.Domain's copy, surfaced by the SDK bump) - VerbCatalogSanity tests: 5/5 passed Refs ADR #173 / #175 (verb-output-schema-registry) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mozart's half of #527 -- Refs #527
This PR delivers the annotation pass + artifact regeneration for the verb-output-schema registry (ADR #173/#175).
What's in scope (Mozart)
All 109 Command methods in src/Polyphony/Commands/ carry [VerbResult(typeof(X))] -- confirmed by matching grep counts. The attributes were already present across all files from prior incremental work; this PR formalises the gap-close and generates the artifact.
Changes
Acceptance criteria status
The other half
Brahms's freshness-check PR (squad/527-schema-freshness-test) is the other half of #527. Both must merge to fully close #527.